[Enhancement] Removed Db() class and updated to use MultiAsicDb() class#1312
Closed
abdosi wants to merge 9 commits intosonic-net:masterfrom
Closed
[Enhancement] Removed Db() class and updated to use MultiAsicDb() class#1312abdosi wants to merge 9 commits intosonic-net:masterfrom
abdosi wants to merge 9 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
to use MultiAsicDb(). With this change moved all instances of pass_db to pass_multi_asic_db. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
This pull request introduces 1 alert when merging 36000b7 into 394b202 - view on LGTM.com new alerts:
|
Contributor
Author
|
retest this please |
Contributor
Author
|
Closing the PR as this can impact other outstanding PR. Will continue to use DB class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Why I did:
This is done so code is generic and all the multi-asic specific changes are present in utilities_common/multi_asic.py and not spread around in db.py
How I verify:
All the unit tests are passing